Repository navigation
fix: false host oversubscription alerts after capacity refactoring - #1543
Merged
Merged
Conversation
…factoring Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
November 17, 2026 11:04
Contributor
Test Coverage ReportTest Coverage 📊: 72.1% |
SoWieMarkus
approved these changes
Nov 17, 2026
This was referenced Nov 17, 2026
Merged
Merged
SoWieMarkus
added a commit
that referenced
this pull request
Nov 17, 2026
## Release cortex 0.9.3 ## Changelog — cortex 0.9.3 **Release PR:** [#1545](#1545) **Date:** 2026-11-17 **App Version:** `sha-67c88600` ### Bumped Versions | Package | Previous | New | |---|---|---| | cortex | 0.9.2 | 0.9.3 | | cortex-postgres | 0.6.34 | 0.6.35 | | cortex-shim | 0.1.40 | 0.1.41 | | bundles | 0.0.116 | 0.0.117 | | cortex-placement-shim | 0.1.40 | 0.1.41 | ### Bug Fixes - **Fixed false host oversubscription alerts after capacity refactoring** ([#1543](#1543)) — After the unified capacity calculation refactoring (#1504), the `computeViolations` function in `HostOversubscriptionController` incorrectly counted `FailoverHost` reservations at full `Spec.Resources` (i.e., entire host capacity). This caused every host with committed-resource reservations **and** running VMs to be falsely reported as oversubscribed. The fix rewrites the violation computation to explicitly select only reservation types that represent real demand on a host's capacity (`CommittedResource`, `Failover`, `InFlight`), excluding `FailoverHost` reservations which block full host capacity for evacuation and are already policed by a dedicated filter. Violations are now computed as `Used + Reserved − Total` per resource, only flagging positive excess. A regression test was added to verify that a failover host reservation with running VMs does not trigger false oversubscription. ## Dependencies - Prep PR: #1546 (must be merged before this PR)
Merged
SoWieMarkus
added a commit
that referenced
this pull request
Nov 17, 2026
## Release cortex 0.9.4 ## cortex 0.9.4 ### Bug Fixes - **Fix false host oversubscription alerts after capacity refactoring** ([#1543](#1543), @mblos) After the unified capacity calculation refactoring (#1504), every host with committed-resource reservations **and** running VMs was incorrectly reported as oversubscribed. This patch corrects the false-positive alerting logic in the host oversubscription controller. ### Helm Chart Versions | Chart | Version | |---|---| | cortex | 0.9.4 | | cortex-postgres | 0.6.36 | | cortex-shim | 0.1.42 | | bundles | 0.0.118 | | cortex-placement-shim | 0.1.42 | ## Dependencies - Prep PR: #1549 (must be merged before this PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the unified capacity calculation refactoring (#1504), every host with committed-resource reservations and running VMs was incorrectly reported as oversubscribed.